Skip to content

fix: handle missing fields gracefully and prevent infinite recursion … #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
matthv wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle missing fields gracefully and prevent infinite recursion … #259

matthv wants to merge 1 commit into from

Conversation

@matthv
Copy link
Member

@matthv matthv commented Feb 5, 2026

…in schema generation

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@qltysh
Copy link

qltysh bot commented Feb 5, 2026

11 new issues

Tool Category Rule Count
qlty Structure Function with high complexity (count = 7): check_many_to_many_published? 5
qlty Structure Function with many returns (count = 6): published? 3
qlty Duplication Found 19 lines of similar code in 2 locations (mass = 93) 2
qlty Structure Function with many parameters (count = 4): log_missing_relation_field 1

qltysh[bot]
qltysh bot reviewed Feb 5, 2026
View reviewed changes
packages/forest_admin_agent/lib/forest_admin_agent/utils/schema/generator_field.rb
end
end

def log_missing_relation_field(collection_name, field_name, field_type, relation_name)
Copy link

@qltysh qltysh bot Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 4): log_missing_relation_field [qlty:function-parameters]

...orest_admin_datasource_customizer/decorators/publication/publication_collection_decorator.rb
end
return check_many_to_many_published?(field, visited) if field.type == 'ManyToMany'

true
Copy link

@qltysh qltysh bot Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many returns (count = 6): published? [qlty:return-statements]

...orest_admin_datasource_customizer/decorators/publication/publication_collection_decorator.rb
return false
end

published?(field.origin_key_target, visited)
Copy link

@qltysh qltysh bot Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many returns (count = 4): check_one_to_x_published? [qlty:return-statements]

...orest_admin_datasource_customizer/decorators/publication/publication_collection_decorator.rb
through_collection.published?(field.foreign_key, visited) &&
through_collection.published?(field.origin_key, visited) &&
published?(field.origin_key_target, visited) &&
foreign_collection.published?(field.foreign_key_target, visited)
Copy link

@qltysh qltysh bot Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 2 issues:

1. Function with many returns (count = 6): check_many_to_many_published? [qlty:return-statements]


2. Function with high complexity (count = 7): check_many_to_many_published? [qlty:function-complexity]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qltysh qltysh[bot] qltysh[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@matthv